[PATCH weston 00/10] wayland-backend fixes

[Quentin Glidic]

On 10/24/17 12:15 PM, Pekka Paalanen wrote:
> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> 
> Hi,
> 
> as part of my clone mode work[1] I obviously should test that I don't regress
> the backends. The Wayland backend made regression testing hard by being already
> broken in many ways. Here is a series to fix the issues I found. The series can
> also be found at:
> 
> https://gitlab.collabora.com/pq/weston/commits/wayland-fixes-v1
> 
> The Wayland-backend testing I did for this series was with a weston.ini that
> made the two parent outputs of different height. The parent compositor was
> using the x11 backend.
> 
> Wayland-backend testing:
> 
> parent: $ weston --output-count=2 --width=700
> 
> tests:
> 
> weston --use-pixman
> weston --use-pixman --fullscreen
> weston --use-pixman --output-count=2
> weston --use-pixman --sprawl
> - close parent outputs one by one
> 
> parent: $ weston --output-count=2 --width=700 --shell=fullscreen-shell.so
> 
> tests:
> 
> weston --use-pixman
> - close parent outputs one by one
> 
> All the above work fine after the fixes. The hotkey to switch between windowed
> and fullscreen (ctrl+alt+f) causes the switch from windowed to fullscreen to
> make the parent xdg-shell unhappy, I did not look into that.
> 
> Thanks to Armin for providing the fix to the black secondary window issue.
> 
> 
> Thanks,
> pq
> 
> [1] https://phabricator.freedesktop.org/T7727
> 
> 
> Armin Krezović (1):
>    compositor-wayland: fix damage coordinates with pixman renderer
> 
> Pekka Paalanen (9):
>    weston: fix boolean wayland backend options
>    compositor-wayland: avoid recursive dispatch with wl_outputs
>    compositor-wayland: remove unused 'scale'
>    compositor-wayland: fix mode_list corruption on --sprawl
>    compositor-wayland: actually free parent_output
>    compositor-wayland: allow to unset fullscreen
>    compositor-wayland: windowed/fullscreen not on fullscreen-shell
>    compositor-wayland: clarify wl_display_connect() error
>    compositor-wayland: fix shm_buffer damage init
> 
>   compositor/main.c              | 15 +++++---
>   libweston/compositor-wayland.c | 84 ++++++++++++++++++++++++++++++------------
>   2 files changed, 70 insertions(+), 29 deletions(-)
> 

Great work!

The whole series is:
Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>

Thanks,

-- 

Quentin “Sardem FF7” Glidic