[PATCH 0/6] libweston: Support multiple seats better

Emil Velikov emil.l.velikov at gmail.com
Thu Sep 7 17:44:11 UTC 2017


Hi nerdopolis,

I'm mostly an outsider here, so just sharing some observations.

On 6 September 2017 at 13:17, nerdopolis <bluescreen_avenger at verizon.net> wrote:
> I am resending as I messed up one of the commit messages, which resulted
> in a very long subject by mistake. These patches fix issues with Weston
> where it supports multiple seats better.
>
Please set your name in git config. I don't know what wayland's stance
is on real names vs nick, personally I think that using a real one
indicates the openness towards the project.

Apart from 4/6 none of the 5 other patches has any commit message. I
recommend reading this post [1] about the importance of one.

[1] http://who-t.blogspot.co.uk/2009/12/on-commit-messages.html

> Firstly supporting automatically detecting the seat to use, by using the
> XDG_SEAT variable set by logind if the --seat option is not specified.
>
> And then improving the fbdev-backend to support the --seat option and
> not hard use seat0
>
> And then to not have weston try to use a TTY when it's not running
> on seat0, as only seat0 can have TTYs
>
> And also attempt to turn on a framebuffer device on, as many secondary
> video cards that support DRM/KMS, such as qemu's bochs, and udl start
> off powered off, and don't turn on the screens until the ioctl is sent
>
> Then finally, make the fbdev-backend detect the first framebuffer device
> assigned to the current seat with udev (I based that largely off of some
> of drm-backend)
>
Speaking of which ... some of this sounds like it should be part of
the respective patches.

HTH
Emil


More information about the wayland-devel mailing list