[PATCH weston 2/3] gl-renderer: Add support for fence sync extensions

[Pekka Paalanen]

On Thu, 14 Sep 2017 13:16:17 +0100
Emil Velikov <emil.l.velikov at gmail.com> wrote:

> Hi Alexandros,
> 
> On 14 September 2017 at 12:07, Alexandros Frantzis
> <alexandros.frantzis at collabora.com> wrote:
> > Check for the EGL_KHR_fence_sync and EGL_ANDROID_native_fence_sync
> > extensions and get pointers to required extension functions.
> > ---
> >  libweston/gl-renderer.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c
> > index 5768f05a..c2e88a65 100644
> > --- a/libweston/gl-renderer.c
> > +++ b/libweston/gl-renderer.c
> > @@ -231,6 +231,11 @@ struct gl_renderer {
> >         int has_dmabuf_import_modifiers;
> >         PFNEGLQUERYDMABUFFORMATSEXTPROC query_dmabuf_formats;
> >         PFNEGLQUERYDMABUFMODIFIERSEXTPROC query_dmabuf_modifiers;
> > +
> > +       int has_native_fence_sync;
> > +       PFNEGLCREATESYNCKHRPROC create_sync;
> > +       PFNEGLDESTROYSYNCKHRPROC destroy_sync;
> > +       PFNEGLDUPNATIVEFENCEFDANDROIDPROC dup_native_fence_fd;  
> Please add fall-back definitions for these in shared/weston-egl-ext.h
> This way Weston will build even against old version of the EGL headers.

Hi,

I agree with Emil. The code already in this patch looks good as well.

Another thing that just came to my mind is about the commit messages.
They should always answer the question "why?". When patches get merged
in upstream, the boundaries of series and the cover-letters disappear.
Hence I favour saying a few words on why the patch was written in each
commit message.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170915/1be4d2fe/attachment-0001.sig>