[PATCH libinput] udev: add quirk for Chalkboard Electronics HID Touchscreen

[Hans de Goede]

Hi,

On 19-09-17 18:41, Matt Porter wrote:
> The Chalkboard Electronics HID Touchscreen is classified as
> a tablet device by systemd udev because it has BTN_TOOL_PEN
> support. It also reports a resolution of 0 for both X and Y
> axes in absinfo. This causes libinput to reject it as an
> invalid tablet device.
> 
> This quirk reclassifies the device as a touchscreen which
> allows it to be added as a valid input device.
> 
> Signed-off-by: Matt Porter <mporter at konsulko.com>

Have you considered adding special handling for this device
to the kernel's hid drivers ? The hid subsys has sub drivers
for device specific handling and if the device never actually
has a pen, then the right fix would be to not make the kernel
export this. Note I assume this is for a so called
"smart" whiteboard for in classes ? If that is the case then
the device may actually have a pen/stylus like device in
some configuration. Some of these smart boards have what
are basically empty whiteboard-marker in multiple colors
and the device may report these as different styluses ...

Regards,

Hans



> ---
>   udev/90-libinput-model-quirks.hwdb | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/udev/90-libinput-model-quirks.hwdb b/udev/90-libinput-model-quirks.hwdb
> index 72fcdca..6348f0c 100644
> --- a/udev/90-libinput-model-quirks.hwdb
> +++ b/udev/90-libinput-model-quirks.hwdb
> @@ -72,6 +72,13 @@ libinput:name:*ETPS/2 Elantech Touchpad*:dmi:*svnASUSTeKCOMPUTERINC.:pnX555LAB:*
>    LIBINPUT_MODEL_TOUCHPAD_VISIBLE_MARKER=1
>   
>   ##########################################
> +# Chalkboard Electronics
> +##########################################
> +libinput:name:Chalkboard Electronics HID Touchscreen:dmi:*
> + ID_INPUT_TABLET=0
> + ID_INPUT_TOUCHSCREEN=1
> +
> +##########################################
>   # Chicony
>   ##########################################
>   # Acer Hawaii Keyboard, uses Chicony VID
>