[PATCH weston 05/21] libweston: weston_output_init(..., +name)

Hardening rdp.effort at gmail.com
Tue Sep 26 07:57:38 UTC 2017

Le 22/09/2017 à 16:31, Pekka Paalanen a écrit :
> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> Add 'name' argument to weston_output_init(). This is much more obvious
> than the assert inside weston_output_init() to ensure the caller has set
> a field in weston_output first.
> Now weston_output_init() will strdup() the name itself, which means we
> can drop a whole bunch of strdup()s in the backends. This matches
> weston_output_destroy() which was already calling free() on the name.
> All backends are slightly reordered to call weston_output_init() before
> accessing any fields of weston_output, except the Wayland backend which
> would make it a little awkward to do it in this patch. Mind, that
> weston_output_init() still does not reset the struct to zero - it is
> presumed the caller has done it, since weston_output is embedded in the
> backend output structs.
> Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Reviewed-by: David Fort <contact at hardening-consulting.com>

More information about the wayland-devel mailing list