[PATCH weston v12 03/40] [TEST] compositor-drm: Allow disabling universal planes

[Emil Velikov]

On 26 September 2017 at 18:15, Daniel Stone <daniels at collabora.com> wrote:
> Add a test environment variable to allow disabling universal planes.
>
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> ---
>  libweston/compositor-drm.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
> index b28e602f..0827e953 100644
> --- a/libweston/compositor-drm.c
> +++ b/libweston/compositor-drm.c
> @@ -2551,8 +2551,10 @@ init_kms_caps(struct drm_backend *b)
>         else
>                 b->cursor_height = 64;
>
> -       ret = drmSetClientCap(b->drm.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> -       b->universal_planes = (ret == 0);
> +       if (!getenv("WESTON_DISABLE_UNIVERSAL_PLANES")) {
> +               ret = drmSetClientCap(b->drm.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> +               b->universal_planes = (ret == 0);
> +       }
Just a general idea, please don't bother with it for now:

Normally it's great if one can have clear description of the format
env. variables expect.
Quick grep shows WAYLAND_DEBUG and this instance.

For bool sounding variables, one would expect FOO=0/1 to work.

-Emil