[PATCH 3/3] rdp-backend.so: OpenGL hardware acceleration

[Pekka Paalanen]

On Fri, 23 Feb 2018 16:08:00 +0100
Raimundo Sagarzazu <rsagarzazu at ulmapackaging.com> wrote:

> Hi,
>  
> Two patches that improve performance in my case. 
>  
> First, supporting ARGB8888 gbm-format for the output allows a much better performance of the intelReadPixels function of the i965 driver of Mesa, which is my case:
>  
> diff -rup a/libweston/compositor-rdp.c b/libweston/compositor-rdp.c
> --- a/libweston/compositor-rdp.c           2018-02-22 11:35:14.000000000 +0100
> +++ b/libweston/compositor-rdp.c        2018-02-22 11:37:20.312159332 +0100
> @@ -592,6 +592,8 @@ parse_gbm_format(const char *s, uint32_t
>                               *gbm_format = default_value;
>                else if (strcmp(s, "xrgb8888") == 0)
>                               *gbm_format = GBM_FORMAT_XRGB8888;
> +             else if (strcmp(s, "argb8888") == 0)
> +                             *gbm_format = GBM_FORMAT_ARGB8888;
>                else if (strcmp(s, "rgb565") == 0)
>                               *gbm_format = GBM_FORMAT_RGB565;
>                else if (strcmp(s, "xrgb2101010") == 0)
>  
> Second, reading just the damaged pixels and y-flipping back the image:

Hi,

thanks for the patches, the ideas look good to me, but the patches
themselves are not formatted such that they could be applied. Please see
https://cgit.freedesktop.org/wayland/wayland/tree/doc/Contributing
for some guidance.

I would expect a re-send of these patches. The OpenGL support in
RDP-backend has not been merged yet, so it would be good to point to
the depended-on patches in your cover letter or even offer a branch
from which people could test.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180403/005232f4/attachment-0001.sig>