[PATCH weston v6 00/73] Head-based output configuration API a.k.a clone mode infrastructure

Daniel Stone daniel at fooishbar.org
Thu Apr 12 10:09:26 UTC 2018

Hi Pekka,

On 16 February 2018 at 15:56, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> here is the v6 of the shared-CRTC clone mode series. Since v5, quite
> many patches have been extracted from this series, sent out and merged
> upstream. However, now the series is bigger than ever, because here I am
> posting the complete series, including the full DRM-backend migration
> and DRM shared-CRTC clone mode implementation, thanks to having the
> basic atomic modesetting landed upstream.

I reviewed clonemode-7-part1 from
https://gitlab.collabora.com/pq/weston, which is slightly revised (&
significantly truncated) compared to this series. Here's a braindump:

When adding head_list to a weston_output, we can't send
wp_presentation_feedback's sync_output event to the same resource for
multiple wl_outputs:

Should be a pretty easy fix (don't iterate through multiple heads once
you've sent an event to at least one head's resource), but I don't
know what the long-term fix is. Maybe there isn't a good one.

I think this is also a small and easily-fixable bug:

The only real interface change I'd like to see is using a listener
list rather than a single callback:

Here are a couple of throwaway comments and nitpicks; feel free to ignore them:

The rest looks good to me! I think it'd be good to merge 'libweston:
cancel idle_repaint on output destroy' ASAP in particular. The fbdev
and RDP patches are quite lazily Acked-by me, as I lost the will to
live whilst trying to review them. The rest of the series, with at
least the first three addressed, is Reviewed-by me.

I like both sides of the new API a lot. Great stuff!


More information about the wayland-devel mailing list