[PATCH weston 21/25] protocol: add weston_touch_calibration

Pekka Paalanen ppaalanen at gmail.com
Wed Apr 18 08:30:42 UTC 2018


On Mon, 16 Apr 2018 13:40:44 +1000
Peter Hutterer <peter.hutterer at who-t.net> wrote:

> On Fri, Apr 13, 2018 at 10:51:37AM +0300, Pekka Paalanen wrote:
> >   
> > I think the appropriate solution for me here is to check whether the
> > normalized value I expect to be in [0, 1] falls outside of the range,
> > and if so, I will a) print a warning in Weston's log that the device
> > may need a quirk like you explained, and b) send the "invalid touch"
> > event instead of a touch event to the calibrator app.
> > 
> > This makes the calibrator app show a big red cross, so the user will
> > know something is strange if he thinks he did touch the correct spot.  
> 
> I'd argue that this is worthy of a custom event, given that the client will
> have to provide a specific UI for this case. But it's also not worth
> worrying about in the first iteration of the protocol.

Right, I won't add another event for now.

> > Well, it does touch-downs at least. I think if motion event would end
> > up out of range, I'll send cancel event followed by invalid touch.
> > Whee, I found use for the cancel event!  
> 
> The cancel event would also be used for the multitouch-case, right?
> If a second touch appears before the first one is fully processed, you also
> need to cancel the first touch. Doesn't even need to be intentional by the
> user, could be a palm touch or an accidental touch where they're holding the
> screen on an edge.

I hadn't even thought of that, sounds good.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180418/57d30b49/attachment-0001.sig>


More information about the wayland-devel mailing list