EXT: [PATCH weston v6 00/73] Head-based output configuration API a.k.a clone mode infrastructure

Pekka Paalanen ppaalanen at gmail.com
Wed Apr 18 11:16:36 UTC 2018


On Tue, 10 Apr 2018 08:56:41 -0500
Derek Foreman <derekf at osg.samsung.com> wrote:

> On 2018-04-10 08:12 AM, Pekka Paalanen wrote:
> > On Sat, 24 Mar 2018 10:16:12 +0000
> > "Ray, Ian (GE Healthcare)" <ian.ray at ge.com> wrote:
> >   
> >>> On 23 Mar 2018, at 19.16, Ray, Ian (GE Healthcare) <ian.ray at ge.com> wrote:
> >>>
> >>>     
> >>>> On 23 Mar 2018, at 15.12, Ray, Ian (GE Healthcare) <ian.ray at ge.com> wrote:
> >>>>
> >>>>     
> >>>>> On 16 Feb 2018, at 16.56, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> >>>>>
> >>>>> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> >>>>>
> >>>>> Hi all,
> >>>>>
> >>>>> here is the v6 of the shared-CRTC clone mode series. Since v5, quite
> >>>>> many patches have been extracted from this series, sent out and merged
> >>>>> upstream. However, now the series is bigger than ever, because here I am
> >>>>> posting the complete series, including the full DRM-backend migration
> >>>>> and DRM shared-CRTC clone mode implementation, thanks to having the
> >>>>> basic atomic modesetting landed upstream.
> >>>>>
> >>>>> The previous submission is here:
> >>>>> https://lists.freedesktop.org/archives/wayland-devel/2017-December/036236.html
> >>>>>
> >>>>> Design discussion etc. (sequence diagrams!) can be found here:
> >>>>> https://phabricator.freedesktop.org/T7727
> >>>>> https://phabricator.freedesktop.org/w/wayland/weston/atomic-output-config/
> >>>>> https://lists.freedesktop.org/archives/wayland-devel/2017-October/035604.html
> >>>>>
> >>>>> The series is available as a branch at:
> >>>>> https://gitlab.collabora.com/pq/weston/commits/clonemode-6
> >>>>>
> >>>>> Highlights since v5:
> >>>>> - DRM-backend migration
> >>>>> - shared-CRTC clone mode implemented in DRM backend
> >>>>> - applied review comments from v5
> >>>>> - don't create a weston_output just to turn it off (DRM)
> >>>>> - cms-colord will print a warning when used with clone mode
> >>>>> - cms-colord vs. clone mode mentioned in weston-drm.man
> >>>>>
> >>>>> Unfortunately the testing results are not 100%, you can find my testing
> >>>>> procedure below the diffstat.
> >>>>>
> >>>>> The patch series is structured as follows:

> > Now I'd just need an Acked-by or two from our oldtimers to land that
> > batch. After that there would be 34 patches left to review in this
> > series.  
> 
> Well, the whole series can certainly be
> Acked-by: Derek Foreman <derekf at osg.samsung.com>

I took this to mean the 73 patches, not just 39 patches.

> >>>>> - Patches 40-44 enhances libweston core to better support the
> >>>>> DRM-backend's clone mode configuration and improve logging.
> >>>>>
> >>>>> - Patches 45-55 implement the head-based API for real in the
> >>>>> DRM-backend, culminating in patch 55 which creates heads for all
> >>>>> connectors.
> >>>>>
> >>>>> - Patch 56 removes unused_connectors array which has been replace with
> >>>>> the head list.
> >>>>>
> >>>>> - Patches 57-70 finally implement everything needed for shared-CRTC
> >>>>> clone mode in the DRM-backend.
> >>>>>
> >>>>> - Patches 71-73 add a new output configrator logic in the frontend to
> >>>>> handle clone mode, supporting a new weston.ini key "same-as".
> >>>>>
> >>>>>
> >>>>> Do you think we should call the weston.ini key "clone-of" instead, to
> >>>>> leave "same-as" reserved for clone mode where only the desktop area is
> >>>>> the same but the monitors would have different video modes, scaling,
> >>>>> etc.?
> >>>>>
> >>>>> There are several imaginable uses for "same-as" variants:
> >>>>> - get me shared-CRTC clone mode or fail
> >>>>> - get me clone mode, preferring shared-CRTC but automatic fallback to
> >>>>> independent CRTCs
> >>>>> - get me clone mode, but I want one monitor with HiDPI and one with
> >>>>> LoDPI  

This question about "same-as" or something else still stands.

I have pushed patches 40-65:
   42c0e148..6fae2be9  master -> master

I will be implementing review feedback so far and posting the remaining
patches again for another look.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180418/21a7cc2d/attachment.sig>


More information about the wayland-devel mailing list