[PATCH 0/2] Add tablet_v2 support to weston-info

[Pekka Paalanen]

On Tue, 24 Apr 2018 09:31:21 +0200
wl at ongy.net wrote:

> From: Markus Ongyerth <wl at ongy.net>
> 
> Hi,
> 
> the first commit adds support for the tablet-unstable-v2 protocol to
> weston-info. It will output the currently attached tablets, tablet_pads and
> tablet_tools with all info provided by the protocol.
> An example output:
> 
> ```
> interface: 'zwp_tablet_manager_v2', version: 1, name: 11
> 	tablet_seat: seat0
> 		tablet: Wacom Intuos3 6x8 Pen
> 			vendor: 1386
> 			product: 177
> 			path: /sys/devices/pci0000:00/0000:00:14.0/usb3/3-2/3-2:1.0/0003:056A:00B1.0019/input/input106/event5
> 		pad:
> 			buttons: 8
> 			path: /sys/devices/pci0000:00/0000:00:14.0/usb3/3-2/3-2:1.0/0003:056A:00B1.0019/input/input108/event6
> 			group:
> 				modes: 1
> 				strips: 2
> 				rings: 0
> 				buttons: 0 1 2 3 4 5 6 7
> 		tablet_tool: pen
> 			hardware serial: 7803f99
> 			hardware wacom: 823
> 			capabilities: tilt pressure distance
> ```
> 
> The second patch is a mostly unrelated patch that fixes a memory-leak in
> weston-info I found while searching for ones I introduced with valgrind
> 
> Cheers,
> ongy
> 
> Markus Ongyerth (2):
>   weston-info: Add support for tablet-unstable-v2
>   weston-info: destroy wl_keyboard
> 
>  Makefile.am           |  14 +-
>  clients/weston-info.c | 854 +++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 859 insertions(+), 9 deletions(-)
> 

Hi,

a nice idea, both patches are:
Acked-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

I'll leave the detailed review for others.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180424/2ca3c796/attachment.sig>