[PATCH v3 weston 4/5] tests: add test for setting gamma

Daniel Stone daniel at fooishbar.org
Fri Aug 3 08:47:01 UTC 2018


Hi Harsha,

On Tue, 24 Jul 2018 at 10:11, Harsha Manjula Mallikarjun (RBEI/ECF3)
<Harsha.ManjulaMallikarjun at in.bosch.com> wrote:
> > So, I understand this would be a manual test where the user would
> > visually verify that the gamma is changing in the way they would
> > expect? I have no problem with that, but it would be nice to see this
> > documented with an example as to what the user should be seeing with
> > each step.
>
> An application showing gamma value on screen along with the image would
> be very nice I thought. Due to lack of time I did this simple plugin which
> just changes Gamma/CTM irrespective of any application that is running. User
> has to run an app manually though.
> I can document with comments in code what is expected on display, with
> each step increment in CTM and gamma values. Would this be fine?

That would be great, thankyou!

> > Also, lastly, is there a public libweston user for this new API?
>
> There is a plan to use this from wayland-ivi-extension. Then a demo
> app will also come along :-).
>
> > It would be nice to have this be configurable.
> I did not get this point. Do you mean that the inclusion of this test would be
> configurable during build time? OR this feature of Gamma and CTM itself needs
> to included based on configuration?

Ah no - always building the support is definitely the right thing to do!

What I meant was some support for loading the configuration of the
degamma LUT + CTM + gamma LUT, either from weston.ini, or udev
properties, or some other file. This way people could calibrate and
then statically configure systems to have the correct values when they
are not required to change dynamically.

Cheers,
Daniel


More information about the wayland-devel mailing list