[v2, weston] gl-renderer.c: Use gr->egl_config to create pbuffer surface

Daniel Stone daniel at fooishbar.org
Fri Aug 3 18:08:58 UTC 2018

Hi Adam,

On Fri, 3 Aug 2018 at 19:05, Adam Jackson <ajax at redhat.com> wrote:
> On Thu, 2018-08-02 at 17:21 -0700, Madhurkiran Harikrishnan wrote:
> > The original implementation always chose first egl config for pbuffer
> > surface type, however the returned configs are implementation specific
> > and egl config may not always match between ctx and surface. Hence,
> > use gr->egl_config which already has the matching config but ensure that
> > windows and pbuffer bit are set for the surface type.
> Does this make pbuffer surface support mandatory? (Or, is it mandatory
> already.) If so it might make more sense to just do:

It's only mandatory if configless_context is not supported.

The patch we need to see from this is: if configless_context is not
supported, select EGL_WINDOW_BIT | EGL_PBUFFER_BIT for gr->egl_config.
Without selecting configs twice, or querying the configs later.


More information about the wayland-devel mailing list