[PATCH weston v5 03/14] libweston: add weston_debug API and implementation

[Pekka Paalanen]

On Mon, 27 Aug 2018 16:20:41 +0100
Daniel Stone <daniel at fooishbar.org> wrote:

> Hi Pekka,
> 
> On Fri, 24 Aug 2018 at 09:12, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > On another matter, I've been wondering if storing the debug scopes in
> > weston_compositor is a good thing. We have the logger initialized
> > earlier, and quite a lot might happen before weston_compositor is
> > created. Also the idea of a circular buffer for after-the-fact
> > reporting might benefit from having debug scopes set up early, and the
> > command line argument to enable debug scopes from launch.  
> 
> Yeah, I think we can definitely rework this to push the scope of the
> debug stuff up. As noted in
> https://gitlab.freedesktop.org/wayland/weston/issues/133 I think it
> would be really good to have all this information as early as
> possible, and maybe even outliving the compositor. From a libweston
> API point of view, having the same API for general logging as we do
> for debug makes a huge amount of sense.
> 
> Given how invasive that would be, my suggestion would be that we track
> that as a follow-up issue. Once we've got all the functionality in
> place we can see for sure what the best API/structure would be.

Agreed.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180828/3fc4f8c2/attachment-0001.sig>