[PATCH v15 01/34] compositor-drm: Track unused connectors and CRTCs

Pekka Paalanen ppaalanen at gmail.com
Tue Feb 6 10:09:42 UTC 2018

On Mon,  5 Feb 2018 18:44:10 +0000
Daniel Stone <daniels at collabora.com> wrote:

> Rather than a more piecemeal approach at backend creation, explicitly
> track connectors and CRTCs we do not intend to use, so we can ensure
> they are disabled where appropriate.
> When we have an updated list of connector and CRTC IDs, we add any which
> are not owned by an enabled drm_output to the list. We remove them from
> the list when drm_output_repaint() is called for that output, and re-add
> them when the output is disabled or destroyed.
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> ---
>  libweston/compositor-drm.c | 89 +++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 88 insertions(+), 1 deletion(-)

Hi Daniel,

this patch now looks technically correct and logically consistent:

Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

I was about to claim the logic could be further simplified, but I forgot
that connectors can appear and disappear on update_outputs().

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180206/eca0b5a8/attachment.sig>

More information about the wayland-devel mailing list