[PATCH weston 3/4] ivi-shell: don't expilicitly assign outputs to views

[Pekka Paalanen]

On Fri, 26 Jan 2018 15:04:58 +0100
Emre Ucan <eucan at de.adit-jv.com> wrote:

> it is assigned in weston_view_assign_outputs
> 
> Signed-off-by: Emre Ucan <eucan at de.adit-jv.com>
> ---
>  ivi-shell/ivi-layout.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c
> index 3c52ce1..4799c25 100644
> --- a/ivi-shell/ivi-layout.c
> +++ b/ivi-shell/ivi-layout.c
> @@ -821,10 +821,6 @@ commit_screen_list(struct ivi_layout *layout)
>  
>  				weston_layer_entry_insert(&layout->layout_layer.view_list,
>  							  &ivi_view->view->layer_link);
> -
> -				ivi_view->view->output = iviscrn->output;

Hi,

I understand the removal of this.

> -				ivi_view->ivisurf->surface->is_mapped = true;
> -				ivi_view->view->is_mapped = true;

However, I would think these are still necessary. Why are they not
necessary here?

I do not see any other place that would set is_mapped=true for the view
and the surface.

>  			}
>  		}
>  	}

Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180207/d06a804c/attachment.sig>