[PATCH weston 1/4] ivi-shell: change layer visibility to bool

[Pekka Paalanen]

On Wed, 7 Feb 2018 10:19:39 +0000
"Ucan, Emre (ADITG/ESB)" <eucan at de.adit-jv.com> wrote:

> Hi Pekka,
> 
> Yes, I know that it is an ABI breakage. But there is already another
> ABI breakage in compositor.h:
> fbf165f5e89576730eed4a7e3979100311c4f0f8 Users of ivi-shell has to
> recompile for weston 4.0 anyway.

Ok. To be honest, I've lost track of what's ABI for you and what's not.
I'd appreciate a note in the commit message, so I see you've thought of
it. Anyway:

Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


Thanks,
pq

> > -----Original Message-----
> > From: Pekka Paalanen [mailto:ppaalanen at gmail.com]
> > Sent: Mittwoch, 7. Februar 2018 11:02
> > To: Ucan, Emre (ADITG/ESB)
> > Cc: wayland-devel at lists.freedesktop.org
> > Subject: Re: [PATCH weston 1/4] ivi-shell: change layer visibility
> > to bool
> > 
> > On Fri, 26 Jan 2018 15:04:56 +0100
> > Emre Ucan <eucan at de.adit-jv.com> wrote:
> >   
> > > ivi_layout_layer_set_visibility has bool
> > > as argument.
> > >
> > > Signed-off-by: Emre Ucan <eucan at de.adit-jv.com>
> > > ---
> > >  ivi-shell/ivi-layout-export.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/ivi-shell/ivi-layout-export.h
> > > b/ivi-shell/ivi-layout-export.h index 277ac59..f656602 100644
> > > --- a/ivi-shell/ivi-layout-export.h
> > > +++ b/ivi-shell/ivi-layout-export.h
> > > @@ -101,7 +101,7 @@ struct ivi_layout_layer_properties
> > >  	int32_t dest_width;
> > >  	int32_t dest_height;
> > >  	enum wl_output_transform orientation;
> > > -	uint32_t visibility;
> > > +	bool visibility;
> > >  	int32_t transition_type;
> > >  	uint32_t transition_duration;
> > >  	double start_alpha;  
> > 
> > Hi Emre,
> > 
> > you acknowledge that this might be an ABI break, and do not care,
> > right? This struct is in an installed header.
> > 
> > 
> > Thanks,
> > pq  

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180207/4269be2a/attachment.sig>