[PATCH weston] xwayland: Fix crash on weston shutdown

Derek Foreman derekf at osg.samsung.com
Wed Feb 7 16:58:45 UTC 2018

On 2018-02-05 04:35 PM, Daniel Stone wrote:
> Hi,
> On 5 February 2018 at 22:02, Derek Foreman <derekf at osg.samsung.com> wrote:
>> commit e7fff215ada3fd3d1b2af664888f960c082f9065 made initializing the
>> selection_listener conditional, but didn't make its clean-up
>> conditional at shutdown.
>> To see this, run weston -Bheadless-backend.so and then connect to it
>> with an X client.  When killing weston it will attempt shutdown but
>> die with a segfault.
> For bonus points, it seems like it should really hang off the seat's
> destroy_signal too ...

Ah, you're probably right.  I might get back to that later.

> wm_list_init() somewhere in init would be more in keeping with the
> rest of the codebase; with that, this is:
> Reviewed-by: Daniel Stone <daniels at collabora.com>

I've switched up to a wm_list_init() and landed this.


> Cheers,
> Daniel

More information about the wayland-devel mailing list