[PATCH weston 2/2] compositor-drm: move state_invalid setting to deinit

Daniel Stone daniel at fooishbar.org
Fri Feb 9 16:50:37 UTC 2018

Hi Pekka,

On 9 February 2018 at 10:29, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> Setting state_invalid to true is moved together with the code adding new
> unused CRTCs and connectors in drm_output_deinit(). Logically these two
> operations belong together: state_invalid is required for the new unused
> item to be turned off.
> This does not hinder initial turning off of outputs, because on
> compositor start-up, state_invalid is initialized to true, making calls
> to drm_output_disable() for non-enabled outputs a no-op.
> Previous changes already ensure that if a compositor does not explicitly
> enable an output, the CRTC and connector will be turned off even without
> an explicit disable (provided there is a at least one enabled output).

Thanks a lot for these two patches. They look good to me, so I've
reviewed and pushed.


More information about the wayland-devel mailing list