[PATCH weston 7/9] compositor-drm: fix uninitialized bytes on modeinfo

Daniel Stone daniel at fooishbar.org
Mon Feb 12 12:28:55 UTC 2018


Hi,

On 9 February 2018 at 13:07, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> index 1897f455..a975b379 100644
> --- a/libweston/compositor-drm.c
> +++ b/libweston/compositor-drm.c
> @@ -4347,6 +4347,8 @@ parse_modeline(const char *s, drmModeModeInfo *mode)
>         char vsync[16];
>         float fclock;
>
> +       *mode = (drmModeModeInfo){};

Second and last nitpick: this is very clever, but should probably just
use memset() like everywhere else.

I'm happy for this to land without seeing another rev.

Cheers,
Daniel


More information about the wayland-devel mailing list