[PATCH wayland 2/6] wayland-egl: make wayland-egl-backend.h C++ safe

Emil Velikov emil.l.velikov at gmail.com
Fri Feb 16 17:00:05 UTC 2018

On 16 February 2018 at 14:22, Arnaud Vrac <rawoul at gmail.com> wrote:
> On Fri, Feb 16, 2018 at 2:53 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 16 February 2018 at 10:49, Daniel Stone <daniel at fooishbar.org> wrote:
>>> Hi Emil,
>>> On 16 February 2018 at 10:40, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>>> On 15 February 2018 at 23:12, Derek Foreman <derekf at osg.samsung.com> wrote:
>>>>> Maybe it's just me, but having different names for the same variable for C
>>>>> vs C++ compilation seems really nasty and potentially surprising.
>>>> Indeed it is surprising. In practise nobody should be using C++.
>>>> The guards are added just for lolz - but we can flip things the other
>>>> way around.
>>>> Namely, error out when using C++ ;-)
>>> I mean, effectively we did before the rename, by using a reserved keyword ...
>> Indeed.
> I'm the one that complained about this compilation issue in the first
> place because the proprietary driver I'm using is implemented in C++.
> While I don't mind renaming the 'private' field in my branch, I'm just
> saying there are EGL/wayland backend implementations in C++ in the
> wild.
Thanks for letting us know. We've went ahead and updated Mesa -
there's nothing that you'll need to address on your end.


More information about the wayland-devel mailing list