[PATCH weston v2 0/6] libweston: Support input_timestamps_unstable_v1

[Pekka Paalanen]

On Fri, 16 Feb 2018 18:44:13 +0200
Alexandros Frantzis <alexandros.frantzis at collabora.com> wrote:

> The input_timestamps_unstable_v1 protocol allows clients to subscribe to
> high-resolution timestamp events for input events (see [1]).
> 
> This patchset implements the input_timestamps_unstable_v1 protocol in libweston
> and also adds tests for the implementation in the weston test suite.
> 
> Patches (1) and (2) introduce some helper code which is used by later patches.
> Patch (2) in particular adds test helpers that also act as a nice example of a
> client side implementation of the input_timestamps_unstable_v1 protocol.
> 
> Patches (3) to (6) implement the protocol in libweston.
> 
> v2 of this patchset has been rebased on the recent libweston changes to improve
> handling of inert input resources, and is thus able to provide similar robust
> handling of inert resources for the input_timestamps_unstable_v1 objects.  See
> each patch for more detailed changes in v2.
> 
> [1] https://lists.freedesktop.org/archives/wayland-devel/2017-December/036320.html
> 
> Alexandros Frantzis (6):
>   shared: Add timespec_eq helper function
>   tests: Introduce input timestamps helper
>   libweston: Introduce input-timestamps support
>   libweston: Implement keyboard timestamps for
>     input_timestamps_unstable_v1
>   libweston: Implement pointer timestamps for
>     input_timestamps_unstable_v1
>   libweston: Implement touch timestamps for input_timestamps_unstable_v1
> 
>  Makefile.am                       |  20 ++-
>  configure.ac                      |   2 +-
>  libweston/compositor.h            |   6 +
>  libweston/input.c                 | 270 ++++++++++++++++++++++++++++++++++++--
>  shared/timespec-util.h            |  13 ++
>  tests/input-timestamps-helper.c   | 177 +++++++++++++++++++++++++
>  tests/input-timestamps-helper.h   |  46 +++++++
>  tests/keyboard-test.c             |  45 +++++++
>  tests/pointer-test.c              |  66 ++++++++++
>  tests/timespec-test.c             |  12 ++
>  tests/touch-test.c                |  46 +++++++
>  tests/weston-test-client-helper.c |  16 +++
>  tests/weston-test-client-helper.h |  12 ++
>  13 files changed, 711 insertions(+), 20 deletions(-)
>  create mode 100644 tests/input-timestamps-helper.c
>  create mode 100644 tests/input-timestamps-helper.h
> 

Hi Alf,

patches 1 and 2 confirmed, patch 3 is
Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Patches 4-6 are otherwise good, except each of them has the one test
that is slightly off I think. I'll elaborate on patch 4. Aside from
that one test issue in each, they all look good to me and would get R-b
otherwise.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180220/ec54ef52/attachment.sig>