[PATCH wayland v2 4/4] tests: add code, public-code and private-code tests

[Pekka Paalanen]

On Thu, 22 Feb 2018 13:03:49 -0600
Derek Foreman <derekf at osg.samsung.com> wrote:

> On 2018-02-22 05:55 AM, Pekka Paalanen wrote:
> > On Thu, 22 Feb 2018 11:23:39 +0000
> > Emil Velikov <emil.l.velikov at gmail.com> wrote:
> >   
> >> From: Emil Velikov <emil.velikov at collabora.com>
> >>
> >> First one is deprecated in favour of the second option.
> >>
> >> The latter is newly introduced and annotates the generated symbols
> >> accordingly.
> >>
> >> v2: Don't introduce small-public-code.c - reuse small-code.c (Pekka)
> >>
> >> Cc: Pekka Paalanen <ppaalanen at gmail.com>
> >> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> >> ---
> >>   Makefile.am                     |  3 +-
> >>   tests/data/small-private-code.c | 71 +++++++++++++++++++++++++++++++++++++++++
> >>   tests/scanner-test.sh           |  4 +++
> >>   3 files changed, 77 insertions(+), 1 deletion(-)
> >>   create mode 100644 tests/data/small-private-code.c

> >> --- a/tests/scanner-test.sh
> >> +++ b/tests/scanner-test.sh
> >> @@ -48,4 +48,8 @@ generate_and_compare "-c code" "small.xml" "small-code-core.c"
> >>   generate_and_compare "-c client-header" "small.xml" "small-client-core.h"
> >>   generate_and_compare "-c server-header" "small.xml" "small-server-core.h"
> >>   
> >> +# The existing "code" must produce result identical to "public-code"
> >> +generate_and_compare "code" "small.xml" "small-code.c"
> >> +generate_and_compare "public-code" "small.xml" "small-code.c"
> >> +generate_and_compare "private-code" "small.xml" "small-private-code.c"
> >>   exit $RETCODE  
> > 
> > Hi Emil,
> > 
> > this is exactly what I had in mind.
> > 
> > Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > 
> > I'll push this series tomorrow if nothing else is heard.
> >   
> 
> All looks good to me as well,
> 
> Reviewed-by: Derek Foreman <derekf at osg.samsung.com>
> 
> for the series.

All pushed:
   76a4e42..b02c401  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180223/3dfe1418/attachment.sig>