[PATCH v14 19/41] compositor-drm: Extract buffer->plane co-ord translation

Daniel Stone daniel at fooishbar.org
Fri Feb 23 17:25:49 UTC 2018


Hi Pekka,

On 23 January 2018 at 14:20, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Wed, 20 Dec 2017 12:26:36 +0000 Daniel Stone <daniels at collabora.com> wrote:
>> +     if (sx1 < 0)
>> +             sx1 = 0;
>> +     if (sy1 < 0)
>> +             sy1 = 0;
>> +     if (sx2 > wl_fixed_from_int(ev->surface->width))
>> +             sx2 = wl_fixed_from_int(ev->surface->width);
>> +     if (sy2 > wl_fixed_from_int(ev->surface->height))
>> +             sy2 = wl_fixed_from_int(ev->surface->height);
>
> If the clamps changed something, we'd need equivalent adjustment in the
> dest, but that seems to be ignored for now.

Hm ... I am feeling particularly dense today, but I can't get my head
around this. Why/how would we need to translate the dest region?

(The rest is all fine though: thankyou!)

Cheers,
Daniel


More information about the wayland-devel mailing list