[PATCH wayland] scanner: Fix broken private-code generation

Pekka Paalanen ppaalanen at gmail.com
Mon Feb 26 08:39:19 UTC 2018


On Fri, 23 Feb 2018 16:45:14 -0600
Derek Foreman <derekf at osg.samsung.com> wrote:

> Pushed with Daniel's RB.

Hi Derek,

this seems to have trivially broken 'make check' by not updating the
reference output files for wayland-scanner.


Thanks,
pq

> On 2018-02-23 04:39 PM, Daniel Stone wrote:
> > Rb me (sorry for mangled phone client formatting ...)
> > 
> > On Fri, 23 Feb 2018, 10:25 pm Derek Foreman, <derekf at osg.samsung.com 
> > <mailto:derekf at osg.samsung.com>> wrote:
> > 
> >     Missing a closing bracket.
> > 
> >     Signed-off-by: Derek Foreman <derekf at osg.samsung.com
> >     <mailto:derekf at osg.samsung.com>>
> >     ---
> >       src/scanner.c | 2 +-
> >       1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> >     diff --git a/src/scanner.c b/src/scanner.c
> >     index c93070c..1737911 100644
> >     --- a/src/scanner.c
> >     +++ b/src/scanner.c
> >     @@ -1748,7 +1748,7 @@ emit_code(struct protocol *protocol, enum
> >     visibility vis)
> >                             "# define __has_attribute(x) 0  /*
> >     Compatibility with non-clang compilers. */\n"
> >                             "#endif\n\n");
> > 
> >     -               printf("#if (__has_attribute(visibility) ||
> >     defined(__GNUC__) && __GNUC__ >= 4\n"
> >     +               printf("#if (__has_attribute(visibility) ||
> >     defined(__GNUC__) && __GNUC__ >= 4)\n"
> >                             "#define WL_PRIVATE __attribute__
> >     ((visibility(\"hidden\")))\n"
> >                             "#else\n"
> >                             "#define WL_PRIVATE\n"
> >     --
> >     2.14.3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180226/30bde319/attachment-0001.sig>


More information about the wayland-devel mailing list