[PATCH] udev: Thinkpad T470 uses the same settings as T450

[Peter Hutterer]

On Tue, Jan 09, 2018 at 10:41:54AM +0100, Tomas Vestelind wrote:
> Hi,
> 
> The trackpoint on my T470p was very choppy when moving it, even though
> the trackpad was fine.
> 
> I applied the following (the attached patch) and it works much better
> now. I'm not sure that this is the correct solution but at least it
> works better.
> 
> Best Regards,
> Tomas Vestelind

> From 5aa334ccac9d700323ff55a199c715335770eb2c Mon Sep 17 00:00:00 2001
> From: Tomas Vestelind <tomas.vestelind at gmail.com>
> Date: Tue, 9 Jan 2018 10:32:07 +0100
> Subject: [PATCH] udev: Thinkpad T470 uses the same settings as T450
> 
> Running without this (i.e using default?) made the Trackpoint very
> choppy on Thinkpad T470p.
> 
> Signed-off-by: Tomas Vestelind <tomas.vestelind at gmail.com>
> ---
>  udev/90-libinput-model-quirks.hwdb | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/udev/90-libinput-model-quirks.hwdb b/udev/90-libinput-model-quirks.hwdb
> index c23ef833..4bebb809 100644
> --- a/udev/90-libinput-model-quirks.hwdb
> +++ b/udev/90-libinput-model-quirks.hwdb
> @@ -196,10 +196,11 @@ libinput:tablet:input:b0003v256Cp*
>  libinput:name:SynPS/2 Synaptics TouchPad:dmi:*svnLENOVO:*:pvrThinkPadX230*
>   LIBINPUT_MODEL_LENOVO_X230=1
>  
> -# Lenovo T450/T460 and all other Lenovos of the *50 and *60 generation,
> -# including the X1 Carbon 3rd gen
> +# Lenovo T450/T460/T470 and all other Lenovos of the *50, *60 and *70
> +# generation, including the X1 Carbon 3rd gen
>  libinput:name:SynPS/2 Synaptics TouchPad:dmi:*svnLENOVO:*:pvrThinkPad??50*:
>  libinput:name:SynPS/2 Synaptics TouchPad:dmi:*svnLENOVO:*:pvrThinkPad??60*:
> +libinput:name:SynPS/2 Synaptics TouchPad:dmi:*svnLENOVO:*:pvrThinkPad??70*:
>  libinput:name:SynPS/2 Synaptics TouchPad:dmi:*svnLENOVO:*:pvrThinkPadX1Carbon3rd:*
>   LIBINPUT_MODEL_LENOVO_T450_TOUCHPAD=1
>   LIBINPUT_ATTR_PALM_PRESSURE_THRESHOLD=150
> -- 
> 2.15.1

I don't think this is the right fix, at least not for your issue. Neither of
the two properties have any effect on the trackpoint behaviour, they only
adjust some parts of the touchpad behavour. But you're saying that the
touchpad itself was fine, so this patch shouldn't have any effect. Are you
sure it's not some unrelated patch from a recent update or something that
fixed the issue for you?

Cheers,
   Peter