[PATCH v14 01/41] compositor-drm: Add shutting_down flag

[Pekka Paalanen]

On Wed, 20 Dec 2017 12:26:18 +0000
Daniel Stone <daniels at collabora.com> wrote:

> Does what it says on the box: is true when the compositor is shutting
> down.
> 
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> ---
>  libweston/compositor-drm.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
> index 3eda70f30..6ac9626d9 100644
> --- a/libweston/compositor-drm.c
> +++ b/libweston/compositor-drm.c
> @@ -184,6 +184,8 @@ struct drm_backend {
>  	int32_t cursor_height;
>  
>  	uint32_t pageflip_timeout;
> +
> +	bool shutting_down;
>  };
>  
>  struct drm_mode {
> @@ -3605,6 +3607,8 @@ drm_destroy(struct weston_compositor *ec)
>  	wl_event_source_remove(b->udev_drm_source);
>  	wl_event_source_remove(b->drm_source);
>  
> +	b->shutting_down = true;
> +
>  	destroy_sprites(b);
>  
>  	weston_compositor_shutdown(ec);

Hi,

this patch is both trivial and lacking any rationale on why it was
written, with obviously no impact on its own. Would be nice for
posterity to have some explanation on the why. I assume it was
something subtle or annoying.

If not squashing into the first patch needing this.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180115/10c51cf9/attachment.sig>