[PATCH v14 01/41] compositor-drm: Add shutting_down flag

[Pekka Paalanen]

On Tue, 16 Jan 2018 15:18:28 +0000
Daniel Stone <daniel at fooishbar.org> wrote:

> Hi Pekka,
> 
> On 15 January 2018 at 15:05, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > this patch is both trivial and lacking any rationale on why it was
> > written, with obviously no impact on its own. Would be nice for
> > posterity to have some explanation on the why. I assume it was
> > something subtle or annoying.
> >
> > If not squashing into the first patch needing this.  
> 
> As you saw later, this is used when have special drm_planes in the
> pre-universal path, where we need divergent destroy paths. This is new
> as of v13 so we can do that; I put it at the start since it was so
> trivial. Happy to include the expanded rationale here or fold it into
> the special-planes (cursor-plane) patch; whichever is better.

Hi,

I don't really mind which way, whichever seems better to you. Either
way, IMHO it would probably warrant a small paragraph on the why in a
commit message.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180116/798f4d45/attachment-0001.sig>