[PATCH v14 05/41] compositor-drm: Use drm_plane for cursor plane

[Pekka Paalanen]

On Tue, 16 Jan 2018 15:39:00 +0000
Daniel Stone <daniel at fooishbar.org> wrote:

> Hi,
> 
> On 16 January 2018 at 08:25, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > On Wed, 20 Dec 2017 12:26:22 +0000
> > Daniel Stone <daniels at collabora.com> wrote:  
> >> +             switch (type) {
> >> +             case WDRM_PLANE_TYPE_CURSOR:
> >> +                     format = GBM_FORMAT_ARGB8888;
> >> +                     break;
> >> +             case WDRM_PLANE_TYPE_PRIMARY:
> >> +                     format = output->gbm_format;  
> >
> > It seems output->gbm_format is not yet set at this time, so it cannot
> > be used here. However, this is fixed in the next patch, and before that
> > this code path is not reached, so technically it's ok.  
> 
> Very right. I think the easiest thing to do is to just delete the
> PRIMARY case here - always falling through to an assert - and only
> handle it in the next patch.

Sounds good, that change is R-b me.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180117/e12b75ca/attachment-0001.sig>