[PATCH v2] server: add log message when client connection is destroyed due to an error

[Fiedler, Mathias]

Hi,

> -----Original Message-----
> From: Derek Foreman [mailto:derekf at osg.samsung.com]
> Sent: Mittwoch, 17. Januar 2018 21:41
> To: Fiedler, Mathias; wayland-devel at lists.freedesktop.org
> Subject: Re: [PATCH v2] server: add log message when client connection is
> destroyed due to an error
> 
> On 2017-12-05 02:49 AM, Mathias Fiedler wrote:
> > The client connection is destroyed by the server in several
> > circumstances. This patch adds log messages in case the connection is
> > destroyed due to an error other than normal hangup.
> >
> > Signed-off-by: Mathias Fiedler <mathias_fiedler at mentor.com>
> 
> This looks good to me.  I can see this being helpful in debugging.
> 
> Reviewed-by: Derek Foreman <derekf at osg.samsung.com>

Thanks for your review.

> I do wonder if anyone is going to think this is too verbose, and want it to be
> optional...  Can a bogus client use this to flood logs?  (Say, by sending an
> incomplete packet and disconnecting?)

A client can already cause a log message by sending an invalid message, e.g. by
using an invalid object id. This patch just adds another message for such case.
The main intent of this patch was to log the other cases.
But the client would have to reconnect after each error to flood the log.

I have no idea for a simple way to make this optional.

-Mathias