[PATCH weston v4] xwm: Add icon support to the frame

[Daniel Stone]

Hi,

On 3 December 2017 at 13:32, Emmanuel Gil Peyrot <linkmauve at linkmauve.fr> wrote:
> On Fri, Dec 01, 2017 at 09:47:57PM +0100, Quentin Glidic wrote:
>> I can’t find "width * 4" in the EWMH spec[1], I guess it’s well-known enough
>> in this case. Maybe we need to check the Cairo stride matches "width * 4",
>> just in case?
>
> To quote the specification:
> “This is an array of 32bit packed CARDINAL ARGB with high byte being A,
> low byte being B. The first two cardinals are width, height. Data is in
> rows, left to right and top to bottom.”
>
> There is no mention of stride or alignment, so the assumption I and
> everyone are doing is that it’s strictly packed.  There also can’t be
> anything else than *4 due to the format requirement.
>
> Maybe I should add a comment instead.

I don't think it really matters much tbh. I've pushed it with
Quentin's review. Thanks!

Cheers,
Daniel