[PATCH v5 6/7] main: don't configure /dev/fb0 by default

[Pekka Paalanen]

On Fri, 29 Dec 2017 13:31:52 -0500
nerdopolis <bluescreen_avenger at verizon.net> wrote:

> ---
>  compositor/main.c | 3 ---
>  1 file changed, 3 deletions(-)

Hi,

the commit message is missing the answer to the question "Why is it bad
to configure /dev/fb0 by default?"


Thanks,
pq

> diff --git a/compositor/main.c b/compositor/main.c
> index ecd034b9..02de108b 100644
> --- a/compositor/main.c
> +++ b/compositor/main.c
> @@ -1454,9 +1454,6 @@ load_fbdev_backend(struct weston_compositor *c,
>  
>  	parse_options(fbdev_options, ARRAY_LENGTH(fbdev_options), argc, argv);
>  
> -	if (!config.device)
> -		config.device = strdup("/dev/fb0");
> -
>  	config.base.struct_version = WESTON_FBDEV_BACKEND_CONFIG_VERSION;
>  	config.base.struct_size = sizeof(struct weston_fbdev_backend_config);
>  	config.configure_device = configure_input_device;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180122/ea6f7187/attachment.sig>