[PATCH wayland 1/4] contributing: how to read the review rules

Pekka Paalanen ppaalanen at gmail.com
Tue Jul 3 10:32:00 UTC 2018


From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

This is to avoid fighting around the letter of the guidelines. This is
not a protocol spec.

Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
---
 CONTRIBUTING.md | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 70d0eca..538613f 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -206,6 +206,11 @@ people with commit access, there needs to be at least one Acked-by from
 someone with commit access. A person with commit access is expected to be
 able to evaluate the patch with respect to the project scope and architecture.
 
+The below review guidelines are intended to be interpreted in spirit, not by
+the letter. There may be circumstances where some guidelines are better
+ignored. We rely very much on the judgement of reviewers and commit rights
+holders.
+
 During review, the following matters should be checked:
 
 - The commit message explains why the change is being made.
-- 
2.16.4



More information about the wayland-devel mailing list