[PATCH wayland 3/4] contributing: about re-sending patches

Pekka Paalanen ppaalanen at gmail.com
Tue Jul 3 10:32:02 UTC 2018


From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

This is what is generally expected from people who re-send patches,
whether the patches are their own or not.

Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
---
 CONTRIBUTING.md | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index cbe02a3..9442d75 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -43,6 +43,14 @@ responsibility for the copyright status of the code.
 
 We won't reject patches that lack S-o-b, but it is strongly recommended.
 
+When you re-send patches, revised or not, it would be very good to document the
+changes compared to the previous revision in the commit message and/or the
+cover letter. If you have already received Reviewed-by or Acked-by tags, you
+should evaluate whether they still apply and include them in the respective
+commit messages. Otherwise the tags may be lost, reviewers miss the credit they
+deserve, and the patches may cause redundant review effort.
+
+
 Tracking patches and following up
 ---------------------------------
 
-- 
2.16.4



More information about the wayland-devel mailing list