[PATCH libinput 1/5] tools: if the execdir is the builddir, add it to the path

Emil Velikov emil.l.velikov at gmail.com
Wed Jul 4 10:29:26 UTC 2018

Hi Peter,

On 28 June 2018 at 00:51, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> When running libinput tools from the builddir, look up the subtools in the
> builddir as well. Otherwise, add the install prefix to the list of lookup
> locations.
> This ensures that a) we're running builddir stuff against builddir stuff, but
> also b) that we're not running builddir stuff against installed stuff because
> that may give us false positives.
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> Similar-ish to the git approach Emil suggested in [1] but git is a lot more
> involved here. Since we only need this for debugging tools, we can pick the
> simpler approach here and simply ignore most of the corner cases.
I think that git does thing in that particular way is to ensure a
consistent lookup approach.
Personally tools_execdir_is_builddir reads like it should return a
bool, sadly no better name comes to mind.

More of an jfyi, than anything else.


More information about the wayland-devel mailing list