EXT: [PATCH weston 2/2] libweston: fix output reflow on removal

[Pekka Paalanen]

On Wed, 4 Jul 2018 13:21:14 +0000
"Ray, Ian (GE Healthcare)" <ian.ray at ge.com> wrote:

> > On 21 Jun 2018, at 15.53, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > 
> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > 
> > This is regression apparently introduced in
> > 0de859ede4bad72b5d3b78e086632f02196d997f, which accidentally swapped the
> > sign of 'delta_width' in the original call site. If one removes an
> > output, the remaining outputs on the right are getting moved even
> > further to the right.
> > 
> > The outputs to the right should be moved to the left instead, to close
> > the gap left by the removed output.
> >   
> 
> Reviewed-by: Ian Ray <ian.ray at ge.com>
> 
> 
> > Reported-by: Tomasz Olszak <olszak.tomasz at gmail.com>
> > Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > ---
> > libweston/compositor.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)

Both pathces pushed:
   92278e08..9711fd98  master -> master


Thanks,
pq

> > 
> > diff --git a/libweston/compositor.c b/libweston/compositor.c
> > index 8e01eacc..516be96b 100644
> > --- a/libweston/compositor.c
> > +++ b/libweston/compositor.c
> > @@ -5409,7 +5409,7 @@ weston_compositor_remove_output(struct weston_output *output)
> > 
> > 	weston_presentation_feedback_discard_list(&output->feedback_list);
> > 
> > -	weston_compositor_reflow_outputs(compositor, output, output->width);
> > +	weston_compositor_reflow_outputs(compositor, output, -output->width);
> > 
> > 	wl_list_remove(&output->link);
> > 	wl_list_insert(compositor->pending_output_list.prev, &output->link);
> > -- 
> > 2.16.4
> > 
> > _______________________________________________
> > wayland-devel mailing list
> > wayland-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/wayland-devel  
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180705/1f1ab8b3/attachment-0001.sig>