[PATCH v16 01/23] compositor-drm: Property accessor can be const

Pekka Paalanen ppaalanen at gmail.com
Fri Jul 6 09:28:01 UTC 2018


On Thu,  5 Jul 2018 18:16:28 +0100
Daniel Stone <daniels at collabora.com> wrote:

> Since it doesn't write to the parameter, we can make it const.
> 
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> ---
>  libweston/compositor-drm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
> index b96e29671..c6b82ac44 100644
> --- a/libweston/compositor-drm.c
> +++ b/libweston/compositor-drm.c
> @@ -568,7 +568,7 @@ to_drm_mode(struct weston_mode *base)
>   */
>  static uint64_t
>  drm_property_get_value(struct drm_property_info *info,
> -		       drmModeObjectPropertiesPtr props,
> +		       const drmModeObjectProperties *props,
>  		       uint64_t def)
>  {
>  	unsigned int i;

Hi,

'info' could be similarly const too.

Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180706/7c33d1fb/attachment.sig>


More information about the wayland-devel mailing list