[PATCH v14 34/41] compositor-drm: Ignore occluded views

[Daniel Stone]

Hi Pekka,

On Fri, 26 Jan 2018 at 12:45, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Wed, 20 Dec 2017 12:26:51 +0000 Daniel Stone <daniels at collabora.com> wrote:
> > @@ -3116,9 +3136,16 @@ drm_output_propose_state(struct weston_output *output_base,
> >               if (next_plane == primary)
> >                       pixman_region32_union(&renderer_region,
> >                                             &renderer_region,
> > -                                           &ev->transform.boundingbox);
> > +                                           &clipped_view);
> > +             else if (output->cursor_plane &&
> > +                      next_plane != &output->cursor_plane->base)
>
> Should this not be:
>
>         if (!output->cursor_plane || next_plane != &output->cursor_plane->base)
>
> so that lack of a cursor plane goes straight to occluded?

Very right. I've force-pushed this fix (and the resultant changes when
rebasing 'Add modes to drm_output_propose_state' as well as 'Return
plane state from plane preparation') to the v17 branch on Collabora
GitLab, but happy to re-send if that makes life easier.

Cheers,
Daniel