[PATCH weston] simple-dmabuf-drm: fix build with --disable-egl

Emilio Pozuelo Monfort emilio.pozuelo at collabora.co.uk
Tue Jul 10 15:38:47 UTC 2018

On 10/07/18 14:52, Pekka Paalanen wrote:
> On Tue, 3 Jul 2018 16:46:29 +0100
> Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> Hi Emilio,
>> On 2 July 2018 at 16:22, Emilio Pozuelo Monfort <pochu27 at gmail.com> wrote:
>>> Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo at collabora.co.uk>
>>> ---
>>> I tried a build with --disable-egl as I didn't have the headers
>>> installed, and it broke here. The EGL usage here seemed optional so I
>>> did that, but I didn't run-test the result. If it would make more sense
>>> to disable the client if EGL support is disabled I can do that.
>>>  clients/simple-dmabuf-drm.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>> Fairly orthogonal question, aimed at wayland devs:
>> Why does this "simple" app has per-device code instead of using
>> gbm_bo_map/unmap?
>> API has been around for 2 years and every half recent Mesa driver has
>> support for it. Only the really old ones do not radeon (r100), r200,
>> nouveau_vieux and i915.
> Hi Emil,
> I've had the same question before myself, but now that you ask it
> again, I don't remember the answer.
> This client was originally written in 2014, and I think at that time
> there were no generic APIs to do what it needed to do. Not sure if
> there were other reasons as well.

I have a semi-working patch for this. I will send it soon to ask for comments.


More information about the wayland-devel mailing list