[PATCH v20 06/10] compositor-drm: Never lift solid surfaces to planes

[Pekka Paalanen]

On Wed, 11 Jul 2018 11:41:30 +0100
Daniel Stone <daniels at collabora.com> wrote:

> This will never work, so don't even try to do it.
> 

True, even more generally than just solid surfaces which are a special
case of a surface that currently does not have a buffer (anymore). This
catches also all wl_shm surfaces with gl-renderer that are larger than
possible cursor size.

In fact, if we find that we could promote a black solid surface to
scanout_plane if it had a buffer, we might be able to do that: turn off
the primary plane and let crtc produce black there. But that's for the
future. :-)

> Signed-off-by: Daniel Stone <daniels at collabora.com>
> ---
>  libweston/compositor-drm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
> index 65079eac0..c7ca6ef79 100644
> --- a/libweston/compositor-drm.c
> +++ b/libweston/compositor-drm.c
> @@ -3348,6 +3348,9 @@ drm_output_propose_state(struct weston_output *output_base,
>  		if (ev->output_mask != (1u << output->base.id))
>  			force_renderer = true;
>  
> +		if (!ev->surface->buffer_ref.buffer)
> +			force_renderer = true;
> +
>  		/* Ignore views we know to be totally occluded. */
>  		pixman_region32_init(&clipped_view);
>  		pixman_region32_intersect(&clipped_view,

Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180711/6e5d5206/attachment.sig>