[PATCH weston 1/3 v4] simple-dmabuf-drm: require zwp_linux_dmabuf_v1 v3

Daniel Stone daniel at fooishbar.org
Fri Jul 13 15:15:28 UTC 2018


Hi Emilio,

On Thu, 12 Jul 2018 at 12:47, Emilio Pozuelo Monfort <pochu27 at gmail.com> wrote:
> @@ -821,16 +820,8 @@ registry_handle_global(void *data, struct wl_registry *registry,
>                 d->fshell = wl_registry_bind(registry,
>                                              id, &zwp_fullscreen_shell_v1_interface, 1);
>         } else if (strcmp(interface, "zwp_linux_dmabuf_v1") == 0) {
> -               int ver;
> -               if (d->req_dmabuf_modifiers)
> -                       ver = 3;
> -               else if (d->req_dmabuf_immediate)
> -                       ver = 2;
> -               else
> -                       ver = 1;
>                 d->dmabuf = wl_registry_bind(registry,
> -                                            id, &zwp_linux_dmabuf_v1_interface,
> -                                            ver);
> +                                            id, &zwp_linux_dmabuf_v1_interface, 3);

This is missing a version check now, which I'll squash in when pushing.

Cheers,
Daniel


More information about the wayland-devel mailing list