[PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

[Guido Günther]

Hi,
On Fri, Jul 13, 2018 at 05:43:50PM +0200, Guido Günther wrote:
> Hi,
> On Thu, Jul 12, 2018 at 01:46:25PM +0200, Emilio Pozuelo Monfort wrote:
> > No need to write libdrm driver specific code for each supported
> > driver, we can just let GBM call the right one for us now.
> 
> This one breaks NV12 on intel when using rootston as compositor for me.
> 
> $ ./weston-simple-dmabuf-drm --import-format=NV12
> Error: zwp_linux_buffer_params.create failed.
> Error: zwp_linux_buffer_params.create failed.
> Error: zwp_linux_buffer_params.create failed.

Reason is that in wlroot's wlr_egl_create_image_from_wl_drm[1] this

    return eglCreateImageKHR(egl->display, EGL_NO_CONTEXT,
                             EGL_LINUX_DMA_BUF_EXT, NULL, attribs);

returns ELG_BAD_ALLOC. The attribs passed in look sane. Looking at
mesa's dri2_create_image_khr_texture that doesn't make much sense so I
wonder if this rings a bell here?
Cheers,
 -- Guido


> 
> I have to check why yet.
>  -- Guido

[1] https://github.com/swaywm/wlroots/blob/master/render/egl.c#L457