[PATCH weston] libinput: Restore keyboard focus after VT switch

[Jamey Sharp]

Hey Daniel, thanks for taking a look! It turns out that this patch worked
in Weston 3, but in Weston 4, commit
85d55540cb64bf97a08b40f79dc66843f8295d3 broke it. I didn't investigate
carefully enough to understand what that commit was for or why it broke
this, but my patch plus a revert of that commit makes Weston 4 work without
side effects we've been able to observe, so that combo is what we've been
using for the last month.

I hope that's useful information…
Jamey

On Sun, Jul 22, 2018, 3:09 AM Daniel Stone <daniel at fooishbar.org> wrote:

> Hi Jamey,
>
> On Wed, 23 May 2018 at 14:16, Jamey Sharp <jamey at minilop.net> wrote:
> > Under Weston's drm-backend, after returning to Weston from another VT,
> > no window has focus.
> >
> > There's already code in notify_keyboard_focus_out and
> > notify_keyboard_focus_in to save and restore focus, respectively; and
> > udev_input_enable eventually calls notify_keyboard_focus_in, by way of
> > evdev_notify_keyboard_focus. But udev_input_disable doesn't currently
> > call notify_keyboard_focus_out.
> >
> > This patch makes udev_input_disable symmetric with udev_input_enable by
> > calling notify_keyboard_focus_out on every seat, to save focus before
> > suspending libinput. In my testing this successfully resolved my issue.
> > However, I don't have a multi-seat setup to verify that it works there
> > too.
>
> This seems correct to me. Peter, any thoughts/comments?
>
> Cheers,
> Daniel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180722/76c2143d/attachment.html>