[RFC wayland] wayland-server: Finally remove deprecated struct wl_buffer definition

[Derek Foreman]

On 2018-07-14 09:46 AM, Daniel Stone wrote:
> Hey Derek,
> On Fri, 16 Feb 2018 at 16:55, Derek Foreman <derekf at osg.samsung.com> wrote:
>> commit d94a8722cb29d8b897672be66ff3c9ff79eab6fe
>> warned this was coming, back in 2013.
>>
>> I've seen libraries that have wayland client and server using functions
>> in the same file.  Since struct wl_buffer still exists as an opaque
>> entity in client code, the vestigial deprecated wl_buffer from the
>> server include will generate warnings when not building with
>> WL_HIDE_DEPRECATED.
> 
> I wonder if it's now too late to land this for the next release. Seems
> good to me though, and certainly people have had enough notice ...
> 
> For landing whenever (I'll happily take your judgement), this is:
> Reviewed-by: Daniel Stone <daniels at collabora.com>

I think it's a slight, but not huge, stretch to call this a bug fix,
since it should be possible to include client and server headers in the
same file even without defining WL_HIDE_DEPRECATED.

I've pushed this now.

Thanks,
Derek

> Cheers,
> Daniel
>