[PATCH wayland 1/2] build: Remove execinfo.h check

Derek Foreman derek.foreman.samsung at gmail.com
Wed Jul 25 17:36:40 UTC 2018


On 2018-07-21 06:13 AM, Daniel Stone wrote:
> The check for the execinfo.h header is only advisory; the build will not
> fail if it is not present, and set HAVE_EXECINFO_H if it is. The check
> was added in commit 5cfdbef3d299 ("build: Allow disabling building of
> wayland libraries") with no obvious use or reasoning.

5cfdbe3d299 just moved it, it was added in commit bc3e020475

It appears to have been accidentally included there, as it doesn't look
relevant to the bug ticket referenced in the commit.

> Remove the no-op check.
> 
> Signed-off-by: Daniel Stone <daniels at collabora.com>

Reviewed-by: Derek Foreman <derek.foreman.samsung at gmail.com>

Though, I wouldn't mind seeing a more accurate commit log. ;)

> ---
>  configure.ac | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 81cf4077..8c2fb822 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -109,7 +109,6 @@ if test "x$enable_libraries" = "xyes"; then
>  	AC_CHECK_DECL(CLOCK_MONOTONIC,[],
>  		      [AC_MSG_ERROR("CLOCK_MONOTONIC is needed to compile wayland libraries")],
>  		      [[#include <time.h>]])
> -	AC_CHECK_HEADERS([execinfo.h])
>  fi
>  
>  PKG_CHECK_MODULES(EXPAT, [expat], [],
> 



More information about the wayland-devel mailing list