[PATCH weston 2/2] Add .gitlab-ci.yml

Emil Velikov emil.l.velikov at gmail.com
Thu Jun 7 10:12:50 UTC 2018


On 7 June 2018 at 08:46, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Wed, 6 Jun 2018 15:37:01 +0100
> Emil Velikov <emil.l.velikov at gmail.com> wrote:
>
>> On 6 June 2018 at 09:56, Pekka Paalanen <ppaalanen at gmail.com> wrote:
>> > On Wed, 6 Jun 2018 09:22:59 +0100
>> > Daniel Stone <daniel at fooishbar.org> wrote:
>> >
>> >> On 6 June 2018 at 09:12, Daniel Stone <daniel at fooishbar.org> wrote:
>> >> > On 6 June 2018 at 09:03, Pekka Paalanen <ppaalanen at gmail.com> wrote:
>> >> >> Distcheck does not --disable-xwayland-test, does it? So should we match
>> >> >> it with the autogen.sh arguments?
>> >> >
>> distcheck uses AM_DISTCHECK_CONFIGURE_FLAGS (if set in the
>> Makefile.am) to override the defaults.
>> Plus the user can further tweak things via the non AM_ version. For example
>>
>> DISTCHECK_CONFIGURE_FLAGS="--disable-xwayland-test" make distcheck
>
> Yeah, that's my point.
>
> DISTCHECK_CONFIGURE_FLAGS is not set and Makefile.am has
>
> AM_DISTCHECK_CONFIGURE_FLAGS = --disable-setuid-install
>
> There is no benefit in using --disable-xwayland-test for autogen.sh,
> because distcheck will use it anyway and it works already it seems.
>
Merely pointing out how you can disable things at distcheck time.
Whether it should be done or not, is up-to you to decide ;-)

Emil


More information about the wayland-devel mailing list