[PATCH weston] configure.ac: bump libdrm requirement to 2.4.68

[Pekka Paalanen]

On Mon, 11 Jun 2018 09:29:49 +1000
Peter Hutterer <peter.hutterer at who-t.net> wrote:

> Had a stale libdrm sitting around which gave me errors, both fixed with the
> .68 version.
> 
> libweston/pixel-formats.c:291:13: error: ‘DRM_FORMAT_NV24’ undeclared here
> (not in a function); did you mean ‘DRM_FORMAT_NV21’?
>    .format = DRM_FORMAT_NV24,
>              ^~~~~~~~~~~~~~~
>              DRM_FORMAT_NV21
> libweston/pixel-formats.c:296:13: error: ‘DRM_FORMAT_NV42’ undeclared here
> (not in a function); did you mean ‘DRM_FORMAT_NV12’?
>    .format = DRM_FORMAT_NV42,
>              ^~~~~~~~~~~~~~~
>              DRM_FORMAT_NV12
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index ba11b6c8..98887502 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -113,7 +113,7 @@ AC_CHECK_FUNCS([mkostemp strchrnul initgroups posix_fallocate])
>  
>  # check for libdrm as a build-time dependency only
>  # libdrm 2.4.30 introduced drm_fourcc.h.
> -PKG_CHECK_MODULES(LIBDRM, [libdrm >= 2.4.30], [], [AC_MSG_ERROR([
> +PKG_CHECK_MODULES(LIBDRM, [libdrm >= 2.4.68], [], [AC_MSG_ERROR([
>       libdrm is a hard build-time dependency for libweston core,
>       but a sufficient version was not found. However, libdrm
>       is not a runtime dependency unless you have features

Hi,

this patch is correct, but I would like to hear more opinions if we
want to bump the hard build-time dependency from release of Jan 2012 to
Apr 2016.

If we do this bump, we could remove the fallback definitions for
DRM_FORMAT_R8 and DRM_FORMAT_GR88.

In case we want to consider bumping even further, DRM_FORMAT_MOD_* were
introduced in 2.4.83 (Aug 2017), and atomic in 2.4.78 (Apr 2017).


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180611/cc1aad63/attachment.sig>