[PATCHv2 wayland 0/8] wayland-scanner: produce code with c99 initializers

Pekka Paalanen ppaalanen at gmail.com
Mon Jun 18 10:36:01 UTC 2018


On Thu, 14 Jun 2018 16:49:37 +0100
Emil Velikov <emil.l.velikov at gmail.com> wrote:

> Hi all,
> 
> Here's a take v2 of the series, with the following changes:
>  - don't trim trailing NULL entries from the wl_interfaces* array
>  - updated tests - separate patches to ease review, to be squashed
> 
> On the question of why, despite the aesthetics these patches make the
> generated files actually understandable by a human being...

Hi Emil,

on the previous round, this concern was raised:

On Tue, 13 Feb 2018 13:36:06 +0000
Daniel Stone <daniel at fooishbar.org> wrote:

> But that being said, my worry is that we don't actually control the
> compilation environment for the scanner output. Scanner output
> currently compiles with '-pedantic -ansi -Wall -Wextra' (at least,
> when inline is defined). This patch changes that requirement, and I
> worry that - like previous discussions on changing scanner output -
> that upgrading Wayland would lead to people hitting compilation
> failures.

What is your rationale for that being a non-issue?


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180618/aa4abc9a/attachment.sig>


More information about the wayland-devel mailing list