[PATCH wayland 2/2] contributing: commit rights

[Pekka Paalanen]

On Tue, 19 Jun 2018 17:58:41 +0100
Emil Velikov <emil.l.velikov at gmail.com> wrote:

> On 18 June 2018 at 14:42, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> >
> > This has been copied from
> > https://cgit.freedesktop.org/xorg/app/intel-gpu-tools/tree/CONTRIBUTING?id=eccae1360d6d01e73c6af2bd97122cef708207ef
> > and slightly edited to better with Wayland and Weston.
> >
> > The intention is to make it easier to give out commit access to new
> > people, let them know what is expected of them, and help the community
> > to grow. Hopefully this will in time improve the patch review throughput
> > and timeliness.
> >
> > The original text was introduced in
> > https://cgit.freedesktop.org/xorg/app/intel-gpu-tools/commit/CONTRIBUTING?id=0350f0e7f6a0e07281445fc3082aa70419f4aac7
> >
> > Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > ---
> >  CONTRIBUTING.md | 33 +++++++++++++++++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >
> > diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> > index 6e74b6d..70d0eca 100644
> > --- a/CONTRIBUTING.md
> > +++ b/CONTRIBUTING.md
> > @@ -246,5 +246,38 @@ clarity suffers.
> >  - The code adheres to the style guidelines.
> >
> >
> > +Commit rights
> > +=============
> > +
> > +Commit rights will be granted to anyone who requests them and fulfills the
> > +below criteria:
> > +
> > +- Submitted some (10 as a rule of thumb) non-trivial (not just simple
> > +  spelling fixes and whitespace adjustment) patches that have been merged
> > +  already.
> > +
> > +- Are actively participating in public discussions about their work (on the
> > +  mailing list or IRC). This should not be interpreted as a requirement to
> > +  review other peoples patches but just make sure that patch submission isn't
> > +  one-way communication. Cross-review is still highly encouraged.
> > +
> > +- Will be regularly contributing further patches. This includes regular
> > +  contributors to other parts of the open source graphics stack who only
> > +  do the occasional development in this project.
> > +
> > +- Agrees to use their commit rights in accordance with the documented merge
> > +  criteria, tools, and processes.
> > +
> > +To apply for commit rights, create a new issue in gitlab for the respective
> > +project and give it the "accounts" label.
> > +
> > +Committers are encouraged to request their commit rights get removed when they
> > +no longer contribute to the project. Commit rights will be reinstated when they
> > +come back to the project.
> > +
> > +Maintainers and committers should encourage contributors to request commit
> > +rights, especially junior contributors tend to underestimate their skills.
> > +
> > +  
> Yay, glad to see some documentation on the topic. I wonder when it
> would have came out, if it wasn't for the gitlab move.
> Either way, thanks for doing this. Fwiw:
> 
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> Aside: it would be a good idea who's review is considered sufficient
> to get merge patches.
> It would be great to spare the fun experiences of wayland-egl.

The section Review starts with a paragraph about that: one R-b is
required, plus someone with commit access must agree which could be the
same R-b or an additional R-b, A-b or S-o-b.

It doesn't help people with commit access to decide if they can agree
or not though, but I would start by relying on people's own judgement
to not ack things they're not sure of.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180620/e5ff32e7/attachment.sig>