[PATCH weston 2/4] shared: remove weston_config_get_libexec_dir()

[Pekka Paalanen]

On Wed, 20 Jun 2018 12:56:16 +0100
Emil Velikov <emil.l.velikov at gmail.com> wrote:

> On 20 June 2018 at 12:04, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > On Tue, 19 Jun 2018 18:02:16 +0100
> > Emil Velikov <emil.l.velikov at gmail.com> wrote:
> >  
> >> On 18 June 2018 at 15:40, Pekka Paalanen <ppaalanen at gmail.com> wrote:  
> >> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> >> >
> >> > Now that WESTON_MODULE_MAP supersedes WESTON_BUILD_DIR for libexec
> >> > binaries, we don't need to check in WESTON_BUILD_DIR anymore.
> >> >
> >> > There was only one user of weston_config_get_libexec_dir(), so remove
> >> > the whole function. There is no reason to export it.
> >> >  
> >> Removal of public API should be accompanied with changing the API/ABI version.
> >> Bump of the DSO ABI is one way to handle it.  
> >
> > That was already done in:
> > https://gitlab.freedesktop.org/wayland/weston/commit/01f60211b2ff3d12bd8bc6a008ba07c30a666760
> > which put us to libweston 5.0.0. We don't bump major twice between
> > releases.
> >  
> Indeed, I did not spot that one. IMHO a small note vaguely like the
> following is a good call.
> 
> "The ABI major was bumped since last release, so there's no need to do
> so again."
> 
> Regardless, the patch is
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Yes.

Actually, this is config-parser. It's not supposed to be exported by
libweston at all, but it gets pulled in because of libshared.la. Looks
like there is more to clean up.

Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180620/336bfe6d/attachment.sig>